slate icon indicating copy to clipboard operation
slate copied to clipboard

Browser-sync not working on Slate V0

Open willwongco opened this issue 7 years ago • 7 comments

Problem

Everything works fine except it's not reloading the browser. It was working fine on another machine, but I'm seeing the same issue if I do a fresh "npm install"

More Information

Tried it on node v11.4.0 and also tried downgrading node to v8.11.1 with @shopify/slate-tools v0.3.3 & v0.14.0.

willwongco avatar Dec 19 '18 07:12 willwongco

@NathanPJF Could this be addressed please? I know V1 is all the rage right now but V0 still has a very valid place in daily workflows, at least until/if V1 will be able to migrate older themes.

ConduciveMammal avatar Feb 17 '19 11:02 ConduciveMammal

I would like to see this get some TLC as well. I have projects that are based on Slate V0.14 and browser reload stopped working at some point and I have not been able to fix it.

To be clear this doesn't work for me with any version of slate. Not even when creating a brand new project with v1.15

The error I see in my console is VM19:1 GET https://192.168.86.246:3002/browser-sync/socket.io/?EIO=3&transport=polling&t=Malzi13 net::ERR_CERT_COMMON_NAME_INVALID

and I think the problem has to be with the certificate on localhost. Any help would be appreciated

hcmlopes avatar Feb 27 '19 17:02 hcmlopes

I'm still running both Slate v0 on some older projects and Slate v1 on newer ones. Switching back to v0 I do have to downgrade to node 6.11.5. It's possible that it works with a slightly newer version, but I do know that I haven't been able to get it to work with node 8+

jonathanmoore avatar Feb 27 '19 17:02 jonathanmoore

I'm still running both Slate v0 on some older projects and Slate v1 on newer ones. Switching back to v0 I do have to downgrade to node 6.11.5. It's possible that it works with a slightly newer version, but I do know that I haven't been able to get it to work with node 8+

@jonathanmoore Thanks for this info. I will try and verify this

hcmlopes avatar Feb 27 '19 17:02 hcmlopes

@jonathanmoore unfortunately removing my current node and replacing it with v6.11.5 did not help my reloading issues. I still think the problem has to do with certificates but don't understand enough to figure this out...

Quite frustrating

hcmlopes avatar Feb 27 '19 17:02 hcmlopes

Does anyone have any updates on this?

snowiesuet avatar Nov 25 '19 01:11 snowiesuet

I would like to see this get some TLC as well. I have projects that are based on Slate V0.14 and browser reload stopped working at some point and I have not been able to fix it.

To be clear this doesn't work for me with any version of slate. Not even when creating a brand new project with v1.15

The error I see in my console is VM19:1 GET https://192.168.86.246:3002/browser-sync/socket.io/?EIO=3&transport=polling&t=Malzi13 net::ERR_CERT_COMMON_NAME_INVALID

and I think the problem has to be with the certificate on localhost. Any help would be appreciated

https://shopify.github.io/slate/docs/create-a-self-signed-ssl-certificate

Hot reload won't work because the browser is blocking the request, use mkcert to create a self signed certificate (as it says above) and also make sure to run mkcert's comman for adding that to the osx keychain (it doesn't say how above but mkcert will throw a warning with the appropriate command to run after.)

oceanep avatar Jan 27 '20 03:01 oceanep