[Flaky test] SerialDeployTest#test_deploying_crs_with_invalid_crd_conditions_fails

[timothysmith0609]

SerialDeployTest#test_deploying_crs_with_invalid_crd_conditions_fails appears to be flaky, curiously I've only noticed it exclusively on the 1.18 CI block, though it doesn't seem to have anything to do with k8s version. On first blush, this appears to be a race condition of cleaning up temporary directories, though I haven't dug too far into it. The naive solution is to rescue ENOENT in delete_globals, but I feel that is probably masking a problem, not fixingf it.

SerialDeployTest#test_deploying_crs_with_invalid_crd_conditions_fails /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `unlink': No such file or directory @ apply2files - /tmp/k8sdeploy-test-deploying-crs-with-invalid-crd--2021f3804b86040820210120-759-1ffyal8.yml (Errno::ENOENT)
--
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `block in remove_file'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:1442:in `platform_support'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:1436:in `remove_file'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:1425:in `remove'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:760:in `block in remove_entry'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:1480:in `postorder_traverse'
  | from /usr/local/lib/ruby/2.6.0/fileutils.rb:758:in `remove_entry'
  | from /usr/src/app/test/integration_test_helper.rb:32:in `block in delete_globals'
  | from /usr/src/app/test/integration_test_helper.rb:32:in `each'
  | from /usr/src/app/test/integration_test_helper.rb:32:in `delete_globals'
  | from /usr/src/app/test/integration_test_helper.rb:24:in `run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:1029:in `run_one_method'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:341:in `run_one_method'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:328:in `block (2 levels) in run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:327:in `each'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:327:in `block in run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:367:in `on_signal'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:354:in `with_info_handler'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:326:in `run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:164:in `block in __run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:164:in `map'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:164:in `__run'
  | from /usr/local/bundle/gems/minitest-5.14.3/lib/minitest.rb:141:in `run'