krane
krane copied to clipboard
Review usage of deprecated field in DaemonSet parent_of_pod? method
Improvement Analysis / Request
During the work on https://github.com/Shopify/kubernetes-deploy/pull/598 to support Kubernetes 1.16 (and move from extensions/v1beta1, we discovered that the templateGeneration field was removed in DaemonSet v1 and was deprecated in this PR:
https://github.com/kubernetes/kubernetes/pull/49454 Related issue: https://github.com/kubernetes/kubernetes/issues/49336
In order to ship Kubernetes 1.16 support sooner we decided to use deprecated.daemonset.template.generation as templateGeneration field was removed in DaemonSet apps/v1 API.
Suggested approach
After https://github.com/Shopify/kubernetes-deploy/pull/598 ships we need to review this code to check if there is a way to avoid the usage of a deprecated field.
DaemonSetSpec v1
DaemonSetSpec v1beta1