krane icon indicating copy to clipboard operation
krane copied to clipboard

Krane restart -f

Open dturn opened this issue 6 years ago • 2 comments

Problem

#548 added the Krane restart command. However, the -f flag as explained in https://docs.google.com/document/d/1oInUsKplYGNWTymPY48xtDCx3x4Cwc-phcEKUkt2v4U/view# was not added.

Possible solution

Add the flag.

Note: Thor merged erikhuda/thor#674 (allows repeatable options), but they haven't cut a release depending on the timeline we may point at a sha.

Alternative solutions

Do not implement the -f because its very useful without erb rendering.

dturn avatar Sep 17 '19 17:09 dturn

I'd like to propose this is not a 1.0 blocker. The -f does not have an analog in kubernetes-restart and adding it to krane restart will not be a breaking change.

dturn avatar Sep 25 '19 23:09 dturn

👍 I'm ok with leaving it out of 1.0

KnVerey avatar Sep 26 '19 16:09 KnVerey