identity_cache icon indicating copy to clipboard operation
identity_cache copied to clipboard

Split the with_deferred_parent_expiration and with_deferred_parent_expiration

Open drinkbeer opened this issue 1 year ago • 1 comments

  • Split the with_deferred_parent_expiration and with_deferred_parent_expiration to ensure the API is backward compatible
  • Add a deprecation message for with_deferred_parent_expiration
  • Restore all the original unit tests of with_deferred_parent_expiration, to ensure the behaviour of it is not changed

Deprecation message (tested with ActiveRecord 7.0 and 7.2): image

drinkbeer avatar Oct 11 '24 17:10 drinkbeer

Tested in my mac with the following version of activerecord gem:

  • activerecord-7.2.0
  • activerecord-7.0.8.5
  • activerecord-7.2.1.1
  • activerecord in main branch

All is ✅ .

drinkbeer avatar Oct 21 '24 19:10 drinkbeer

So:

Always fire the deprecation notice for .with_deferred_parent_expiration Maintain compatibility between the two APIs for now Seek to remove this method as a breaking change at the earliest convenience

Yah all of these points make sense to me 👍 I think always firing the deprecation notice would be good.

grcooper avatar Oct 22 '24 13:10 grcooper