hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

[skeleton] Close aside when Esc is pressed

Open frontsideair opened this issue 1 year ago • 1 comments

WHY are these changes introduced?

The aside doesn't follow ARIA APG about dismissing with Esc key

WHAT is this pull request doing?

Adds an event handler to dismiss the aside with the Esc key

HOW to test your changes?

  1. Click the search link on the header navigation
  2. Press Esc key to dismiss

Post-merge steps

Checklist

  • [x] I've read the Contributing Guidelines
  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've added a changeset if this PR contains user-facing or noteworthy changes
  • [ ] I've added tests to cover my changes
  • [ ] I've added or updated the documentation

frontsideair avatar Sep 06 '24 21:09 frontsideair

Thanks again @frontsideair. We're in the middle of a release but can merge this shortly after!

scottdixon avatar Sep 10 '24 01:09 scottdixon

CI failing on CSP tests which have been fixed. Confirmed tests pass with a rebase. Merging!

scottdixon avatar Sep 30 '24 02:09 scottdixon