hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

[Hydrogen Skeleton] There is no collections/all page in the Hydrogen skeleton like there is for Liquid

Open BrendaSegalShopify opened this issue 2 years ago • 2 comments

What is the location of your example repository?

No response

Which package or tool is having this issue?

Hydrogen

What version of that package or tool are you using?

xxxx

What version of Remix are you using?

No response

Steps to Reproduce

cc @juanpprieto this is the issue covering what we discussed in our Hydrogen Developer Tools research meeting.

Visiting /collections/all on my Hydrogen storefront leads to a 404

Expected Behavior

In Liquid, Shopify has a default /collections/all that returns all products, regardless of collections.

If available through the Storefront API, we should have a way to do something similar in Hydrogen. Note that if the merchant creates a collection called all, /collections/all should route to that collection, not to the default /collections/all (all products). This would be consistent with the behaviour in Liquid.

Actual Behavior

already described

BrendaSegalShopify avatar Feb 14 '24 15:02 BrendaSegalShopify

https://github.com/Shopify/hydrogen/pull/1967

jamalsoueidan avatar Apr 11 '24 18:04 jamalsoueidan

I think it's missing:

Note that if the merchant creates a collection called all, /collections/all should route to that collection, not to the default /collections/all (all products). This would be consistent with the behaviour in Liquid.

@juanpprieto

jamalsoueidan avatar Apr 11 '24 18:04 jamalsoueidan