hydrogen icon indicating copy to clipboard operation
hydrogen copied to clipboard

Add breadcrumbs

Open sergejasadchij opened this issue 2 years ago • 4 comments

WHAT is this pull request doing?

This adds the usual breadcrumbs functionality common to e-commerce

WHAT is this pull request doing?

Adds Breadcrumbs to pages.

There are different view of the breadcrumbs on mobile and decktop screens. изображение

изображение

By default bredcrumbs on HomePage is hidden, but it is posiible to show it.

HOW to test your changes?

  • Go to any page other than the HomePage
  • Click on different parts of the Breadcrumbs
  • Check it on mobile and desktop screens

Checklist

  • [x] I've read the Contributing Guidelines
  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've added a changeset if this PR contains user-facing or noteworthy changes
  • [ ] I've added tests to cover my changes
  • [ ] I've added or updated the documentation

sergejasadchij avatar Feb 14 '24 09:02 sergejasadchij

@mynameisadamf what do you think about this UX improvement?

blittle avatar Feb 14 '24 20:02 blittle

@blittle How are these breadcrumbs being populated? We did present the idea of adding breadcrumbs prior, following the OS solution, but was manual. If dynamically populated referencing the collection, what happens when the product is assigned to more than one collection?

mynameisadamf avatar Feb 16 '24 19:02 mynameisadamf

How are these breadcrumbs being populated? We did present the idea of adding breadcrumbs prior, following the OS solution, but was manual. If dynamically populated referencing the collection, what happens when the product is assigned to more than one collection?

@mynameisadamf They are just following the URL Home | collections | collection-handle. There is no nested collections. It's just a basic one-level breadcrumps navigation

juanpprieto avatar Mar 05 '24 22:03 juanpprieto

@juanpprieto

They are just following the URL Home | collections | collection-handle

It's just a basic one-level breadcrumbs navigation

But if a merchant can assign a product to many collections. Which collection-handle would display in the breadcrumb?

I'm just making sure we're demoing the right solution for a real-world scenario.

mynameisadamf avatar Mar 12 '24 20:03 mynameisadamf

@sergejasadchij since we move demo store to a different repo. I am going to close this. Feel free to open again on https://github.com/Shopify/hydrogen-demo-store (I truly wish github have a feature where I can move it over 🙏 )

michenly avatar May 29 '24 18:05 michenly