draggable icon indicating copy to clipboard operation
draggable copied to clipboard

[DO NOT MERGE] Example for new page generator

Open beefchimi opened this issue 8 years ago • 5 comments

This PR exists to show what files need to be added / edited in order to complete the new page generator.

@Promhize , if you are still interested in taking this on, take a look over the edited files to see what is new / modified.

For certain things like content/index.js or styles/examples-app.scss, its fine if you can't add the import / init in the exact locations seen in my file diff... as long as the correct files are imported and initialized, thats fine by me.

Using the Files changed as an example, this is what my new page interaction would have looked like:


Under what group does this Example belong?

> 1. Draggable 2. Droppable 3. Sortable 4. Swappable 5. Plugins

What is the name of this Example?

> New example

Provide a roughly 150-character description of this example.

> This is the description I was asked to enter during the "new page" generator that Promhize built.


Please let me know if you have any questions!

beefchimi avatar Jan 18 '18 22:01 beefchimi

@beefchimi, this definitely makes it clearer. I'll start working on generating the files, if I find anything unclear, I'll let you know

promisetochi avatar Jan 19 '18 09:01 promisetochi

Hey @beefchimi, sorry about the delay in fixing #110.

Would make a PR for it this weekend.

promisetochi avatar Feb 02 '18 15:02 promisetochi

@Promhize no worries at all dude!

I'm working on a bit of a clean-up PR for examples/ leading up to us hosting this on the site. Shouldn't affect you much, if at all, and I'm happy to help with the rebase if conflicts arise 👍

https://github.com/Shopify/draggable/pull/133

beefchimi avatar Feb 02 '18 15:02 beefchimi

@beefchimi thanks mate

promisetochi avatar Feb 02 '18 15:02 promisetochi

@Promhize I merged that big refactor PR and rebased this branch off the latest master - so, if you haven't started yet, you are safe to checkout the latest master and start from there 👍

Apologies for any inconvenience!

beefchimi avatar Feb 03 '18 03:02 beefchimi