Follow-up refactoring from #5728
WHY are these changes introduced?
Closes https://github.com/Shopify/cli/pull/5728#discussion_r2067855575
This is a follow-up refactoring from PR #5728.
WHAT is this pull request doing?
This PR removes the hasErrors parameter from handleJsonOutput, as the method now directly receives results since PR #5728.
How to test your changes?
N/A β This is a no-op PR and doesn't change the behavior of shopify theme push --json.
Post-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [x] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [x] I've considered possible documentation changes
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
I'm not including a changelog, because there's no change in behavior.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 76.63% (+0.01% πΌ) |
9601/12529 |
| π‘ | Branches | 71.96% (+0.02% πΌ) |
4750/6601 |
| π‘ | Functions | 76.56% | 2485/3246 |
| π‘ | Lines | 77.14% (+0.01% πΌ) |
9073/11762 |
Test suite run success
2271 tests passing in 983 suites.
Report generated by π§ͺjest coverage report action from a8fa66f1e66a895b446eb546a58585b8558f8466