Add card present payments app extension schema
WHY are these changes introduced?
- closes https://github.com/shop/issues-retail-on-payments-platform/issues/174
- depends on https://github.com/Shopify/partners/pull/59179
Adds a new payments app extension type card present for supporting retail in person payments on PPP.
WHAT is this pull request doing?
Adds schema for CardPresent payments app extensions.
How to test your changes?
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [x] I've considered possible documentation changes
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 77.91% (+0.02% πΌ) |
12417/15938 |
| π‘ | Branches | 72.09% (+0.05% πΌ) |
6022/8354 |
| π‘ | Functions | 78.17% (+0.01% πΌ) |
3258/4168 |
| π‘ | Lines | 78.36% (+0.02% πΌ) |
11748/14993 |
Show new covered files π£
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π’ | ... / card_present_payments_app_extension_schema.ts |
100% | 100% | 100% | 100% |
Show files with reduced coverage π»
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π΄ | ... / payments_app_extension.ts |
50% (-4.55% π») |
14.29% (-2.38% π») |
100% | 50% (-4.55% π») |
Test suite run success
2853 tests passing in 1251 suites.
Report generated by π§ͺjest coverage report action from 2d383a528743bbb1eb401d7ae83655ee0a9b8ebb
/snapit
π«°β¨ Thanks @kerfootj! Your snapshot has been published to npm.
Test the snapshot by installing your package globally:
pnpm i -g @shopify/[email protected]
[!TIP] If you get an
ETARGETerror, install it with NPM and the flag--@shopify:registry=https://registry.npmjs.org
[!CAUTION] After installing, validate the version by running just
shopifyin your terminal. If the versions don't match, you might have multiple global instances installed. Usewhich shopifyto find out which one you are running and uninstall it.