cli icon indicating copy to clipboard operation
cli copied to clipboard

Add card present payments app extension schema

Open kerfootj opened this issue 9 months ago β€’ 3 comments

WHY are these changes introduced?

  • closes https://github.com/shop/issues-retail-on-payments-platform/issues/174
  • depends on https://github.com/Shopify/partners/pull/59179

Adds a new payments app extension type card present for supporting retail in person payments on PPP.

WHAT is this pull request doing?

Adds schema for CardPresent payments app extensions.

How to test your changes?

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

kerfootj avatar May 08 '25 17:05 kerfootj

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

github-actions[bot] avatar May 08 '25 17:05 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
77.91% (+0.02% πŸ”Ό)
12417/15938
🟑 Branches
72.09% (+0.05% πŸ”Ό)
6022/8354
🟑 Functions
78.17% (+0.01% πŸ”Ό)
3258/4168
🟑 Lines
78.36% (+0.02% πŸ”Ό)
11748/14993
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / card_present_payments_app_extension_schema.ts
100% 100% 100% 100%
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
πŸ”΄
... / payments_app_extension.ts
50% (-4.55% πŸ”»)
14.29% (-2.38% πŸ”»)
100%
50% (-4.55% πŸ”»)

Test suite run success

2853 tests passing in 1251 suites.

Report generated by πŸ§ͺjest coverage report action from 2d383a528743bbb1eb401d7ae83655ee0a9b8ebb

github-actions[bot] avatar May 08 '25 17:05 github-actions[bot]

/snapit

kerfootj avatar May 15 '25 18:05 kerfootj

🫰✨ Thanks @kerfootj! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

[!TIP] If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar May 15 '25 18:05 github-actions[bot]