Shopify
Add build logging to app watcher for esbuild-based extensions
WHY are these changes introduced?
UI extensions currently don't output any logging for successful builds, unlike Functions.
WHAT is this pull request doing?
Adds logging for esbuild-managed builds to the app watcher.
How to test your changes?
Add a UI extension and pnpm shopify app dev --path <your app>
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [X] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [X] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
-
#5765
👈 (View in Graphite)
-
main
This stack of pull requests is managed by Graphite. Learn more about stacking.
We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.
[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 76.61% (-0.36% 🔻) |
9582/12508 |
| 🟡 | Branches | 71.87% (-0.45% 🔻) |
4725/6574 |
| 🟡 | Functions | 76.55% (-0.21% 🔻) |
2484/3245 |
| 🟡 | Lines | 77.12% (-0.36% 🔻) |
9055/11742 |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / extension-instance.ts |
84.62% (-0.59% 🔻) |
79.37% (-2.38% 🔻) |
92.59% | 85.16% |
| 🟢 | ... / flow_action.ts |
90% (-10% 🔻) |
100% | 75% (-25% 🔻) |
90% (-10% 🔻) |
| 🟢 | ... / bundle.ts |
78.57% (-3.78% 🔻) |
75% (-12.5% 🔻) |
80% | 84.62% (-2.88% 🔻) |
| 🟢 | ... / link.ts |
96.55% | 92.42% (-0.43% 🔻) |
100% | 96.39% |
| 🔴 | ... / extension.ts |
56.9% (-1.44% 🔻) |
57.14% (-2.86% 🔻) |
50% | 57.89% (-1.43% 🔻) |
| 🟢 | ... / dev-session.ts |
80.31% (-5.1% 🔻) |
62.5% (-6.62% 🔻) |
90% (-1.89% 🔻) |
82.46% (-5.24% 🔻) |
| 🟢 | ... / serialize-fields.ts |
95% (-2.5% 🔻) |
87.5% (-3.13% 🔻) |
100% | 97.44% |
| 🟢 | ... / binaries.ts |
97.3% (+1.09% 🔼) |
89.66% (+2.16% 🔼) |
94.44% (-0.29% 🔻) |
97.3% (+1.09% 🔼) |
| 🟡 | ... / build.ts |
78.69% (-1% 🔻) |
64.58% | 78.38% (-0.57% 🔻) |
77.19% (-1.14% 🔻) |
| 🟡 | ... / developer-platform-client.ts |
69.7% (-8.08% 🔻) |
68.42% (-3.01% 🔻) |
80% (-3.33% 🔻) |
74.07% (-7.98% 🔻) |
| 🟢 | ... / mkcert.ts |
93.33% (-3.59% 🔻) |
76% (-8.85% 🔻) |
100% | 93.02% (-5.39% 🔻) |
| 🔴 | ... / app-management-client.ts |
41.78% (-2.59% 🔻) |
36.75% (-4.02% 🔻) |
40% (-2% 🔻) |
40.37% (-2.84% 🔻) |
| 🔴 | ... / partners-client.ts |
25.66% (-0.97% 🔻) |
31.58% | 16.95% (-1.38% 🔻) |
25.34% (-1.01% 🔻) |
| 🟡 | ... / generate.ts |
67.16% (-0.48% 🔻) |
57.45% | 50% | 72.58% (-0.44% 🔻) |
| 🟢 | ... / api.ts |
83.65% (-1.92% 🔻) |
70.77% (-3.08% 🔻) |
100% | 83% (-2% 🔻) |
| 🟡 | ... / exchange.ts |
80% | 64% (-6.37% 🔻) |
84.62% | 79.31% |
| 🟢 | ... / ConcurrentOutput.tsx |
98.36% (-1.64% 🔻) |
88% (-4% 🔻) |
100% | 98.33% (-1.67% 🔻) |
| 🔴 | ... / system.ts |
37.5% (-16.07% 🔻) |
28.57% (-16.67% 🔻) |
54.55% (-9.09% 🔻) |
38.18% (-16.36% 🔻) |
| 🟢 | ... / version.ts |
88.89% (-0.58% 🔻) |
90% | 100% | 87.5% (-0.74% 🔻) |
| 🟢 | ... / admin.ts |
80% (-0.43% 🔻) |
44.44% | 90.91% | 81.82% (-0.4% 🔻) |
| 🟢 | ... / graphql.ts |
100% | 75% (-12.1% 🔻) |
100% | 100% |
| 🟡 | ... / api.ts |
66.25% (-0.21% 🔻) |
52.05% | 66.67% | 68.21% (-0.21% 🔻) |
Test suite run success
2250 tests passing in 980 suites.
Report generated by 🧪jest coverage report action from 8bde45b25bf474a80ce35f72f7dbe153d3709ed1