cli icon indicating copy to clipboard operation
cli copied to clipboard

Add terminal payment extension.

Open haskelash-shopify opened this issue 9 months ago β€’ 1 comments

WHY are these changes introduced?

Part of issue https://github.com/shop/issues-retail-on-payments-platform/issues/51

RPP is no longer just enabling cloud terminals, but local terminals as well. Because of this we're renaming the extension to the more general terminal_payment_extension.

WHAT is this pull request doing?

Rename extension spec and relevant files

How to test your changes?

Tophatting instructions can be found in this doc.

Post-release steps

The extensions in the bogus app and Adyen app will need to be renamed as well.

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

haskelash-shopify avatar May 06 '25 16:05 haskelash-shopify

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
76.61% (-0.01% πŸ”»)
9587/12514
🟑 Branches
71.87% (-0.01% πŸ”»)
4727/6577
🟑 Functions
76.53% (-0.02% πŸ”»)
2485/3247
🟑 Lines
77.12% (-0.01% πŸ”»)
9060/11748
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
🟑
... / terminal_payments_app_extension_schema.ts
66.67% 100% 0% 66.67%
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
πŸ”΄
... / payments_app_extension.ts
50% (-4.55% πŸ”»)
14.29% (-2.38% πŸ”»)
100%
50% (-4.55% πŸ”»)
🟒
... / ConcurrentOutput.tsx
98.36% (-1.64% πŸ”»)
88% (-4% πŸ”»)
100%
98.33% (-1.67% πŸ”»)

Test suite run success

2251 tests passing in 981 suites.

Report generated by πŸ§ͺjest coverage report action from 76a51643949620997b26b74e1cf1565d87681854

github-actions[bot] avatar May 06 '25 16:05 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Jun 06 '25 03:06 github-actions[bot]