cli icon indicating copy to clipboard operation
cli copied to clipboard

Add production-mode flag to app dev command

Open zzooeeyy opened this issue 9 months ago β€’ 3 comments

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

zzooeeyy avatar Apr 23 '25 17:04 zzooeeyy

This stack of pull requests is managed by Graphite. Learn more about stacking.

zzooeeyy avatar Apr 23 '25 17:04 zzooeeyy

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 76.68% 9481/12365
🟑 Branches 71.79% 4654/6483
🟑 Functions 76.45% 2457/3214
🟑 Lines 77.22% 8967/11613

Test suite run success

2205 tests passing in 959 suites.

Report generated by πŸ§ͺjest coverage report action from d1590d8e40ba71ee30e7594ad3d918c700f70515

github-actions[bot] avatar Apr 23 '25 17:04 github-actions[bot]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/common/array.d.ts
@@ -45,17 +45,4 @@ export declare function uniqBy<T>(array: List<T> | null | undefined, iteratee: V
  * @param values - The arrays of values to exclude.
  * @returns Returns the new array of filtered values.
  */
-export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
-/**
- * Converts an array of anything into a human friendly list.
- *
- * Returns a new array that contains the items separated by commas,
- * except for the last item, which is separated by "and".
- * This is useful for creating human-friendly sentences.
- *
- * @param items - Token[].
- * @returns Token[].
- * @example
- * 
- */
-export declare function asHumanFriendlyArray<T>(items: T[]): (T | string)[];
\ No newline at end of file
+export declare function difference<T>(array: List<T> | null | undefined, ...values: List<T>[]): T[];
\ No newline at end of file

packages/cli-kit/dist/public/node/api/business-platform.d.ts
@@ -40,6 +40,6 @@ export declare function businessPlatformOrganizationsRequest<T>(query: string, t
  * @param variables - GraphQL variables to pass to the query.
  * @returns The response of the query of generic type <T>.
  */
-export declare function businessPlatformOrganizationsRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables> | TypedDocumentNode<TResult, Exact<{
+export declare function businessPlatformOrganizationsRequestDoc<TResult>(query: TypedDocumentNode<TResult, GraphQLVariables> | TypedDocumentNode<TResult, Exact<{
     [key: string]: never;
-}>>, token: string, organizationId: string, variables?: TVariables): Promise<TResult>;
\ No newline at end of file
+}>>, token: string, organizationId: string, variables?: GraphQLVariables): Promise<TResult>;
\ No newline at end of file

github-actions[bot] avatar Apr 23 '25 20:04 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar May 24 '25 03:05 github-actions[bot]