cli icon indicating copy to clipboard operation
cli copied to clipboard

Store module schemas alongside app

Open shauns opened this issue 10 months ago β€’ 5 comments

WHAT is this pull request doing?

Adds a new refreshSchemaBank function that stores JSON schemas from extension specifications in the .shopify/schemas directory. This enables better IDE integration for extension configuration validation.

How to test your changes?

Run this CLI against any app, and see that the .shopify/schemas folder is updated.

shauns avatar Apr 04 '25 14:04 shauns

This stack of pull requests is managed by Graphite. Learn more about stacking.

shauns avatar Apr 04 '25 14:04 shauns

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Apr 04 '25 14:04 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
77.94% (+0.05% πŸ”Ό)
12430/15949
🟑 Branches
72.11% (+0.06% πŸ”Ό)
6028/8359
🟑 Functions
78.21% (+0.05% πŸ”Ό)
3262/4171
🟑 Lines
78.38% (+0.05% πŸ”Ό)
11760/15003

Test suite run success

2847 tests passing in 1249 suites.

Report generated by πŸ§ͺjest coverage report action from 0ba9d0a96290667915336128743077238cae2598

github-actions[bot] avatar Apr 04 '25 14:04 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar May 09 '25 03:05 github-actions[bot]

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run pnpm changeset add to track your changes and include them in the next release CHANGELOG.

[!CAUTION] DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release.

github-actions[bot] avatar May 19 '25 13:05 github-actions[bot]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/fs.d.ts
@@ -103,13 +103,13 @@ export declare function writeFile(path: string, data: string | Buffer, options?:
  */
 export declare function writeFileSync(path: string, data: string): void;
 /**
- * Creates a directory at the given path.
+ * Creates a directory at the given path. Directories are created recursively if needed.
  *
  * @param path - Path to the directory to be created.
  */
 export declare function mkdir(path: string): Promise<void>;
 /**
- * Synchronously creates a directory at the given path.
+ * Synchronously creates a directory at the given path. Directories are created recursively if needed.
  *
  * @param path - Path to the directory to be created.
  */

github-actions[bot] avatar May 20 '25 11:05 github-actions[bot]