cli icon indicating copy to clipboard operation
cli copied to clipboard

Upgrade vitest

Open gonzaloriestra opened this issue 1 year ago β€’ 10 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-inner-loop/issues/2552 Fixes https://github.com/Shopify/cli/security/dependabot/122

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

gonzaloriestra avatar Feb 04 '25 09:02 gonzaloriestra

/snapit

gonzaloriestra avatar Feb 06 '25 13:02 gonzaloriestra

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Feb 06 '25 13:02 github-actions[bot]

/snapit

gonzaloriestra avatar Feb 17 '25 14:02 gonzaloriestra

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

[!TIP] If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Feb 17 '25 14:02 github-actions[bot]

/snapit

gonzaloriestra avatar Feb 17 '25 15:02 gonzaloriestra

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

[!TIP] If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Feb 17 '25 15:02 github-actions[bot]

/snapit

gonzaloriestra avatar Feb 18 '25 08:02 gonzaloriestra

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

[!TIP] If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

[!CAUTION] After installing, validate the version by running just shopify in your terminal. If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Feb 18 '25 08:02 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Mar 21 '25 03:03 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
76.95% (-0.02% πŸ”»)
9735/12651
🟑 Branches
72.37% (+0.05% πŸ”Ό)
4819/6659
🟑 Functions
76.73% (-0.03% πŸ”»)
2509/3270
🟑 Lines
77.46% (-0.02% πŸ”»)
9202/11880
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / marketing_activity_schema.ts
96.15% (-3.85% πŸ”»)
87.5% (-12.5% πŸ”»)
100%
96.15% (-3.85% πŸ”»)
🟒
... / Dev.tsx
85.88% (-7.06% πŸ”»)
75% (-3.57% πŸ”»)
81.82% (-9.09% πŸ”»)
86.25% (-7.5% πŸ”»)

Test suite run success

2295 tests passing in 994 suites.

Report generated by πŸ§ͺjest coverage report action from cf2fc10bdf53b9caf53a6713b3badf6abfb1de18

github-actions[bot] avatar May 12 '25 14:05 github-actions[bot]