cli icon indicating copy to clipboard operation
cli copied to clipboard

Add Ruby Removal changesets

Open jamesmengo opened this issue 1 year ago β€’ 2 comments

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

jamesmengo avatar Oct 07 '24 21:10 jamesmengo

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 07 '24 21:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.72% (+0.04% πŸ”Ό)
8562/11774
🟑 Branches
69.71% (+0.06% πŸ”Ό)
4204/6031
🟑 Functions
71.69% (-0.03% πŸ”»)
2211/3084
🟑 Lines
73.05% (+0.04% πŸ”Ό)
8104/11094
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / function-upload-url-generate.ts
100% 100% 100% 100%
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / app.test-data.ts
91.4% (-0.45% πŸ”»)
91.09%
81.01% (-1.04% πŸ”»)
90.8% (-0.47% πŸ”»)
🟒
... / app.ts
87.07%
70.89% (-0.72% πŸ”»)
92% 88.37%
🟒
... / specification.ts
93.1% (-1.81% πŸ”»)
90.48%
87.5% (-0.5% πŸ”»)
92% (-2.12% πŸ”»)
🟒
... / function.ts
86.36% (-0.59% πŸ”»)
86.36% 83.33%
86.36% (-0.59% πŸ”»)
🟑
... / update-extension.ts
64.86% (-5.14% πŸ”»)
54.55% (-3.79% πŸ”»)
60%
68.75% (-5.54% πŸ”»)
🟑
... / build.ts
74.49%
59.09% (-2.27% πŸ”»)
75.76% 72.22%
πŸ”΄
... / app-management-client.ts
20.75% (-0.09% πŸ”»)
10.26%
22.58% (-0.25% πŸ”»)
19% (-0.09% πŸ”»)
πŸ”΄
... / partners-client.ts
26.87% (-0.2% πŸ”»)
40%
18.18% (-0.34% πŸ”»)
26.56% (-0.21% πŸ”»)
🟒
... / ConcurrentOutput.tsx
98.39% (-1.61% πŸ”»)
90.91% (-4.55% πŸ”»)
100%
98.33% (-1.67% πŸ”»)

Test suite run success

1947 tests passing in 876 suites.

Report generated by πŸ§ͺjest coverage report action from 371d53d3e584f0ce5a21194c59159adce140efc8

github-actions[bot] avatar Oct 07 '24 21:10 github-actions[bot]