Shopify
[Themes] Remove Ruby invocation from the `app dev` command
WHY are these changes introduced?
Closes https://github.com/Shopify/develop-advanced-edits/issues/362
WHAT is this pull request doing?
- Remove
legacyflag fromapp devcommand - Delete
theme-app-extension.js(legacy implementation) - Update imports + tests
How to test your changes?
- Try running
app devwith the legacy flag. This should complain about a non-existent flag
Post-release steps
- https://github.com/Shopify/cli/pull/4593
- https://github.com/Shopify/cli/pull/4595
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [x] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [x] I've considered possible documentation changes
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-inner-loop
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.8% (+0.29% 🔼) |
8551/11746 |
| 🟡 | Branches | 69.75% (+0.66% 🔼) |
4199/6020 |
| 🟡 | Functions | 71.81% (+0.04% 🔼) |
2209/3076 |
| 🟡 | Lines | 73.13% (+0.32% 🔼) |
8094/11068 |
Show new covered files 🐣
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / function-upload-url-generate.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / active-app-release.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / app-version-by-id.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / app-versions.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / apps.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / create-app-version.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / create-app.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / create-asset-url.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / organization.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / release-version.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / specifications.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / user-info.ts |
100% | 100% | 100% | 100% |
| 🟢 | ... / authorize.ts |
100% | 75% | 100% | 100% |
| 🔴 | ... / post-auth.ts |
44.12% | 0% | 0% | 45.45% |
| 🔴 | ... / redirect-listener.ts |
14.75% | 0% | 33.33% | 15% |
Show files with reduced coverage 🔻
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | ... / app.test-data.ts |
91.4% | 91.09% (-0.09% 🔻) |
81.01% | 90.8% |
| 🟢 | ... / app.ts |
87.07% | 70.89% (-0.72% 🔻) |
92% | 88.37% |
| 🟢 | ... / specification.ts |
93.1% (-1.81% 🔻) |
90.48% | 87.5% (-0.5% 🔻) |
92% (-2.12% 🔻) |
| 🟢 | ... / function.ts |
86.36% (-0.59% 🔻) |
86.36% | 83.33% | 86.36% (-0.59% 🔻) |
| 🟢 | ... / app-context.ts |
100% | 87.5% (-1.97% 🔻) |
100% | 100% |
| 🟢 | ... / deploy.ts |
87.18% | 85% (-2.5% 🔻) |
87.5% | 89.19% |
| 🟢 | ... / generate.ts |
100% | 80% (-2.14% 🔻) |
100% | 100% |
| 🟢 | ... / show.ts |
100% | 66.67% (-8.33% 🔻) |
100% | 100% |
| 🔴 | ... / extension.ts |
55.26% (-0.29% 🔻) |
50% | 57.14% | 56.76% (-0.06% 🔻) |
| 🟢 | ... / theme-extension-args.ts |
86.67% | 50% (-12.5% 🔻) |
100% | 86.67% |
| 🟡 | ... / update-extension.ts |
64.86% (-5.14% 🔻) |
54.55% (-3.79% 🔻) |
60% | 68.75% (-5.54% 🔻) |
| 🟡 | ... / build.ts |
74.49% | 59.09% (-2.27% 🔻) |
75.76% | 72.22% |
| 🟢 | ... / extension.ts |
91.4% (+0.09% 🔼) |
73.58% | 91.3% (-0.36% 🔻) |
91.21% (+0.1% 🔼) |
| 🔴 | ... / app-management-client.ts |
20.75% (-0.09% 🔻) |
10.26% (+0.5% 🔼) |
22.58% (-0.25% 🔻) |
19% (-0.09% 🔻) |
| 🔴 | ... / partners-client.ts |
26.87% (-0.2% 🔻) |
40% | 18.18% (-0.34% 🔻) |
26.56% (-0.21% 🔻) |
| 🟢 | ... / session.ts |
81.01% (-1.99% 🔻) |
72.32% (-0.41% 🔻) |
92.86% | 80.67% (-2.09% 🔻) |
| 🟢 | ... / ConcurrentOutput.tsx |
98.39% (-1.61% 🔻) |
90.91% (-4.55% 🔻) |
100% | 98.33% (-1.67% 🔻) |
| 🟡 | ... / fs.ts |
62.5% | 84.62% (-7.05% 🔻) |
58.97% | 62.5% |
| 🟢 | ... / admin.ts |
82.76% (+1.51% 🔼) |
37.5% (-2.5% 🔻) |
90% | 85.71% (+1.84% 🔼) |
Test suite run success
1947 tests passing in 876 suites.
Report generated by 🧪jest coverage report action from e7d58bf060a13c4a28e1364ff5c2118cdb98c780
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.
Test the snapshot by intalling your package globally:
pnpm i -g @shopify/[email protected]
After installing, validate the version by running just
shopifyin your terminal If the versions don't match, you might have multiple global instances installed. Usewhich shopifyto find out which one you are running and uninstall it.
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.
Test the snapshot by intalling your package globally:
pnpm i -g @shopify/[email protected]
After installing, validate the version by running just
shopifyin your terminal If the versions don't match, you might have multiple global instances installed. Usewhich shopifyto find out which one you are running and uninstall it.
🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.
Test the snapshot by intalling your package globally:
pnpm i -g @shopify/[email protected]
After installing, validate the version by running just
shopifyin your terminal If the versions don't match, you might have multiple global instances installed. Usewhich shopifyto find out which one you are running and uninstall it.