cli icon indicating copy to clipboard operation
cli copied to clipboard

[Themes] Remove Ruby invocation from `theme dev` command

Open jamesmengo opened this issue 1 year ago β€’ 3 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-advanced-edits/issues/354

WHAT is this pull request doing?

  • Remove legacy flag from theme dev command
  • Remove Ruby invocation in theme dev command

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

jamesmengo avatar Oct 01 '24 21:10 jamesmengo

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 01 '24 21:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.55% (+0.01% πŸ”Ό)
8417/11602
🟑 Branches
69.12% (+0.02% πŸ”Ό)
4137/5985
🟑 Functions 71.96% 2199/3056
🟑 Lines
72.82% (+0.01% πŸ”Ό)
7960/10931

Test suite run success

1925 tests passing in 873 suites.

Report generated by πŸ§ͺjest coverage report action from b981aea41c5f1e5539213dca5cb00b31313a4a43

github-actions[bot] avatar Oct 01 '24 21:10 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Oct 07 '24 17:10 github-actions[bot]

/snapit

nickwesselman avatar Oct 09 '24 20:10 nickwesselman

🫰✨ Thanks @nickwesselman! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g @shopify/[email protected]

After installing, validate the version by running just shopify in your terminal If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Oct 09 '24 20:10 github-actions[bot]

We detected some changes at packages/*/src and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Oct 22 '24 20:10 github-actions[bot]