cli icon indicating copy to clipboard operation
cli copied to clipboard

[Themes] Remove Ruby from `theme console` command

Open jamesmengo opened this issue 1 year ago β€’ 3 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-advanced-edits/issues/350

WHAT is this pull request doing?

This pull request focuses on cleaning up and simplifying the Console class in the theme package by removing deprecated and unused code. The most important changes include removing unnecessary imports, flags, and methods related to legacy implementations and port handling.

Code Cleanup and Simplification:

  • Removes Ruby CLI2 invocations from the theme console command
  • Removes legacy and port flags

How to test your changes?

  • Run the command with the legacy or port flags

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [x] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes

cc: @Shopify/advanced-edits

jamesmengo avatar Oct 01 '24 20:10 jamesmengo

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-inner-loop

github-actions[bot] avatar Oct 01 '24 20:10 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.63% (-0.08% πŸ”»)
8520/11731
🟑 Branches
69.55% (-0.14% πŸ”»)
4177/6006
🟑 Functions
71.61% (-0.08% πŸ”»)
2205/3079
🟑 Lines
72.95% (-0.09% πŸ”»)
8062/11052
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / loader.ts
94.35% (-0.05% πŸ”»)
86.21% (+0.41% πŸ”Ό)
98% (-0.02% πŸ”»)
95.38% (-0.04% πŸ”»)
🟒
... / context.ts
91.7% (-0.03% πŸ”»)
87.28% 88.57%
92.65% (-0.03% πŸ”»)
πŸ”΄
... / dev.ts
9.65% (-10.35% πŸ”»)
1.56% (-13.36% πŸ”»)
15.79% (-8.6% πŸ”»)
9.52% (-11.35% πŸ”»)
🟑
... / local-storage.ts
69.44% (-1.61% πŸ”»)
57.14% (-5.36% πŸ”»)
72.73%
67.65% (-1.8% πŸ”»)
🟒
... / link.ts
96.51% (-0.08% πŸ”»)
91.94% (-0.25% πŸ”»)
100%
96.39% (-0.09% πŸ”»)

Test suite run success

1938 tests passing in 873 suites.

Report generated by πŸ§ͺjest coverage report action from 055dadab12d4d18d962153f4bf7f03c4eb7a8ad6

github-actions[bot] avatar Oct 01 '24 20:10 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Oct 01 '24 21:10 github-actions[bot]