cli icon indicating copy to clipboard operation
cli copied to clipboard

[Feature]: Disable toml file formatting when running shopify app dev

Open patjakubik opened this issue 1 year ago • 13 comments

What area(s) will this request affect?

Running your code locally

What type of change do you want to see?

Substantial change to existing feature

Overview

Could you add an option to disable formatting when running shopify app dev? Or perhaps format it with the editor's default formatter?

Motivation

It formats differently than the Even Better TOML VScode extension - annoying.

patjakubik avatar Jul 30 '24 08:07 patjakubik

Thanks for the suggestion. Could you provide some examples of what's being formatted differently?

cc: @nickwesselman

gonzaloriestra avatar Jul 30 '24 09:07 gonzaloriestra

@gonzaloriestra here you go

Screenshot 2024-07-30 at 14 25 04@2x

patjakubik avatar Jul 30 '24 12:07 patjakubik

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Sep 11 '24 03:09 github-actions[bot]

Still relevant and still annoying 😅

patjakubik avatar Sep 11 '24 08:09 patjakubik

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Oct 24 '24 03:10 github-actions[bot]

Not stale. Stale bot sucks.

jagthedrummer avatar Nov 06 '24 16:11 jagthedrummer

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Dec 19 '24 03:12 github-actions[bot]

Not stale. Please disable the stale bot. It makes it seem like you don't care to hear from people using your software.

jagthedrummer avatar Dec 19 '24 19:12 jagthedrummer

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Feb 01 '25 03:02 github-actions[bot]

STILL not stale. Please disable the sucky bot.

jagthedrummer avatar Feb 01 '25 19:02 jagthedrummer

This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

P.S. You can learn more about why we stale issues here.

github-actions[bot] avatar Mar 16 '25 03:03 github-actions[bot]

Not stale. And that bot still sucks.

jagthedrummer avatar Mar 23 '25 14:03 jagthedrummer

The latest version of the CLI (3.79) has an experimental new toml parser that shouldn't affect your custom formatting.

To try it set this environment variable: SHOPIFY_CLI_USE_WASM_TOML_PATCH=1.

Let us know if it works!

isaacroldan avatar May 06 '25 15:05 isaacroldan

Didn't quite help here. Left side is formatted with even better toml, right is running npm run dev with the same domain and with that env. By formatting again it goes back to the left

Image

jiaxin-lin avatar Jun 25 '25 17:06 jiaxin-lin

Is it updating the values in redirect_urls when running app dev?

The CLI won't affect the format for lines is not updating (because it literally doesn't touch them), but if it needs to update a field it doesn't know how to "keep" a format (it can be anything!)

We are working towards not updating the toml at all during dev, stay tuned for updates :)

I'll close this issue since this is all we can do for now. There is no need for the env var in the latest version btw, is the default behaviour.

isaacroldan avatar Jun 26 '25 08:06 isaacroldan