cli icon indicating copy to clipboard operation
cli copied to clipboard

Hack days (36): PoC of generating source maps

Open jamesvidler opened this issue 1 year ago β€’ 8 comments

See https://docs.google.com/document/d/1iqd_oyvC-gigP3knw7TIkMJ4L_QO_dqDbusQ_dQ78-s/edit

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes

jamesvidler avatar Jun 27 '24 17:06 jamesvidler

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

github-actions[bot] avatar Jun 27 '24 17:06 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
72.62% (+0.11% πŸ”Ό)
7913/10897
🟑 Branches
69.39% (+0.05% πŸ”Ό)
3885/5599
🟑 Functions
71.33% (+0.03% πŸ”Ό)
2077/2912
🟑 Lines
72.95% (+0.12% πŸ”Ό)
7478/10251

Test suite run success

1805 tests passing in 822 suites.

Report generated by πŸ§ͺjest coverage report action from cfd7059da881101c43afb94b857c254eeb14ca5a

github-actions[bot] avatar Jun 27 '24 17:06 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Jul 29 '24 03:07 github-actions[bot]

/snapit

jamesvidler avatar Aug 06 '24 20:08 jamesvidler

This is still relevant. We are planning to ship this along with some updates in core to handle authenticated sourcemaps. We also intend to use snapit for tophatting this change.

jamesvidler avatar Aug 06 '24 20:08 jamesvidler

/snapit

jamesvidler avatar Aug 06 '24 20:08 jamesvidler

/snapit

jamesvidler avatar Aug 06 '24 20:08 jamesvidler

🫰✨ Thanks @jamesvidler! Your snapshot has been published to npm.

Test the snapshot by intalling your package globally:

pnpm i -g [email protected]

After installing, validate the version by running just shopify in your terminal If the versions don't match, you might have multiple global instances installed. Use which shopify to find out which one you are running and uninstall it.

github-actions[bot] avatar Aug 06 '24 20:08 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Sep 06 '24 03:09 github-actions[bot]