cli
cli copied to clipboard
Update QA scripts to support global CLI
WHY are these changes introduced?
As part of the release QA process we want to test that a global installation of the CLI works as expected.
WHAT is this pull request doing?
- Add a new flag to the app QA script to install the CLI globally.
- Install and run the global CLI when required.
- Don't install @shopify/theme anymore
How to test your changes?
Run different combinations of node bin/create-test-app.js (with --global, -i nightly, -i experimental, ...)
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
- [ ] I've made sure that any changes to
devordeployhave been reflected in the internal flowchart.
Thanks for your contribution!
Depending on what you are working on, you may want to request a review from a Shopify team:
- Themes: @shopify/advanced-edits
- UI extensions: @shopify/ui-extensions-cli
- Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
- Hydrogen: @shopify/hydrogen
- Other: @shopify/app-management
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 72.05% | 7019/9742 |
| π‘ | Branches | 68.94% | 3469/5032 |
| π‘ | Functions | 71.49% | 1881/2631 |
| π‘ | Lines | 73.37% | 6616/9017 |
Test suite run success
1649 tests passing in 766 suites.
Report generated by π§ͺjest coverage report action from 40689c9ba6853f19f9a17d762b5412ee9268a323