cli icon indicating copy to clipboard operation
cli copied to clipboard

`app versions list` and `app release`

Open amcaplan opened this issue 1 year ago β€’ 2 comments

WHY are these changes introduced?

Filling out more commands

WHAT is this pull request doing?

Adds ShopifyDevelopersClient support for app versions list and app release

How to test your changes?

On prototype, run app versions list and app release (note that app release is still WIP, we will mark this PR as Ready for Review once it's ready)

Measuring impact

How do we know this change was effective? Please choose one:

  • [x] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes
  • [x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

amcaplan avatar May 12 '24 13:05 amcaplan

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

github-actions[bot] avatar May 12 '24 13:05 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
71.75% (-0.19% πŸ”»)
7085/9875
🟑 Branches
68.86% (-0.07% πŸ”»)
3513/5102
🟑 Functions
71.36% (-0.09% πŸ”»)
1894/2654
🟑 Lines
73.03% (-0.23% πŸ”»)
6668/9131
Show new covered files 🐣
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / app-version-by-id.ts
100% 100% 100% 100%
🟒
... / app-versions.ts
100% 100% 100% 100%
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / release.ts
93.33% (-0.42% πŸ”»)
60% 75%
92.86% (-0.48% πŸ”»)
πŸ”΄
... / partners-client.ts
18.35% (-0.52% πŸ”»)
34.62% 15.22%
18.27% (-0.54% πŸ”»)
🟒
... / ConcurrentOutput.tsx
97.62% (-2.38% πŸ”»)
75% (-8.33% πŸ”»)
100%
97.44% (-2.56% πŸ”»)

Test suite run success

1660 tests passing in 769 suites.

Report generated by πŸ§ͺjest coverage report action from 2ba0f38c1d5ddae9e5ab6708c8159f6ea21acaf6

github-actions[bot] avatar May 12 '24 13:05 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar May 20 '24 18:05 github-actions[bot]