Deploy multiple webhook subscription modules
WHY are these changes introduced?
Fixes https://github.com/Shopify/develop-app-management/issues/1720 and https://github.com/Shopify/develop-app-management/issues/1724
See https://github.com/Shopify/develop-app-management/issues/1720 for more details and testing instructions
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
- [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
- [ ] Existing analytics will cater for this addition
- [ ] PR includes analytics changes to measure impact
Checklist
- [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
- [ ] I've considered possible documentation changes
- [ ] I've made sure that any changes to
devordeployhave been reflected in the internal flowchart.
We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.
Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| π‘ | Statements | 71.98% (+0.2% πΌ) |
7010/9739 |
| π‘ | Branches | 68.85% (+0.16% πΌ) |
3457/5021 |
| π‘ | Functions | 71.5% (+0.28% πΌ) |
1884/2635 |
| π‘ | Lines | 73.28% (+0.2% πΌ) |
6608/9018 |
Show files with reduced coverage π»
St.:grey_question: |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| π’ | ... / app.test-data.ts |
93.06% (+0.25% πΌ) |
93.83% (-0.98% π») |
83.56% (+0.46% πΌ) |
92.5% (+0.24% πΌ) |
| π’ | ... / breakdown-extensions.ts |
96.49% (+0.06% πΌ) |
82.76% (-0.57% π») |
100% | 100% |
Test suite run success
1641 tests passing in 766 suites.
Report generated by π§ͺjest coverage report action from 017baff5a0b0a640334fc69e47bc9afd321bd968
Unused types (1)
| Filename | types |
|---|---|
| packages/app/src/cli/models/extensions/specification.ts | UidStrategy |
This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.