cli icon indicating copy to clipboard operation
cli copied to clipboard

Deploy multiple webhook subscription modules

Open gracejychang opened this issue 1 year ago β€’ 3 comments

WHY are these changes introduced?

Fixes https://github.com/Shopify/develop-app-management/issues/1720 and https://github.com/Shopify/develop-app-management/issues/1724

See https://github.com/Shopify/develop-app-management/issues/1720 for more details and testing instructions

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [ ] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [ ] I've considered possible documentation changes
  • [ ] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

gracejychang avatar Apr 20 '24 00:04 gracejychang

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Apr 20 '24 00:04 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
71.98% (+0.2% πŸ”Ό)
7010/9739
🟑 Branches
68.85% (+0.16% πŸ”Ό)
3457/5021
🟑 Functions
71.5% (+0.28% πŸ”Ό)
1884/2635
🟑 Lines
73.28% (+0.2% πŸ”Ό)
6608/9018
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / app.test-data.ts
93.06% (+0.25% πŸ”Ό)
93.83% (-0.98% πŸ”»)
83.56% (+0.46% πŸ”Ό)
92.5% (+0.24% πŸ”Ό)
🟒
... / breakdown-extensions.ts
96.49% (+0.06% πŸ”Ό)
82.76% (-0.57% πŸ”»)
100% 100%

Test suite run success

1641 tests passing in 766 suites.

Report generated by πŸ§ͺjest coverage report action from 017baff5a0b0a640334fc69e47bc9afd321bd968

github-actions[bot] avatar Apr 23 '24 19:04 github-actions[bot]

Unused types (1)

Filename types
packages/app/src/cli/models/extensions/specification.ts UidStrategy

github-actions[bot] avatar May 01 '24 20:05 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar Jun 03 '24 03:06 github-actions[bot]