cli icon indicating copy to clipboard operation
cli copied to clipboard

[WIP] Added is_marketplace, use_shopify_tax and marketplace_registrations t…

Open mchemanishop opened this issue 1 year ago β€’ 3 comments

Relies on

WHY are these changes introduced?

Fixes #0000

WHAT is this pull request doing?

How to test your changes?

Post-release steps

Measuring impact

How do we know this change was effective? Please choose one:

  • [ ] n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • [ ] Existing analytics will cater for this addition
  • [ ] PR includes analytics changes to measure impact

Checklist

  • [x] I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • [x] I've considered possible documentation changes
  • [x] I've made sure that any changes to dev or deploy have been reflected in the internal flowchart.

mchemanishop avatar Apr 19 '24 14:04 mchemanishop

Thanks for your contribution!

Depending on what you are working on, you may want to request a review from a Shopify team:

  • Themes: @shopify/advanced-edits
  • UI extensions: @shopify/ui-extensions-cli
    • Checkout UI extensions: @shopify/checkout-ui-extensions-api-stewardship
  • Hydrogen: @shopify/hydrogen
  • Other: @shopify/app-management

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

We detected some changes at either packages/*/src or packages/cli-kit/assets/cli-ruby/** and there are no updates in the .changeset. If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

github-actions[bot] avatar Apr 19 '24 14:04 github-actions[bot]

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
71.98% (-0.01% πŸ”»)
6976/9691
🟑 Branches
69% (+0.04% πŸ”Ό)
3441/4987
🟑 Functions 71.21% 1855/2605
🟑 Lines
73.29% (-0.01% πŸ”»)
6580/8978
Show files with reduced coverage πŸ”»
St.:grey_question:
File Statements Branches Functions Lines
🟒
... / utilities.ts
97.44% (-0.06% πŸ”»)
84.62% (+4.62% πŸ”Ό)
80%
97.44% (-0.06% πŸ”»)
🟑
... / generate.ts
66.13% (-1.06% πŸ”»)
58.54% (+2.72% πŸ”Ό)
50%
70.18% (-1.01% πŸ”»)

Test suite run success

1656 tests passing in 765 suites.

Report generated by πŸ§ͺjest coverage report action from b127bf170b651a3467d12bd2943c99186d736a4a

github-actions[bot] avatar Apr 19 '24 17:04 github-actions[bot]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. β†’ If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.

github-actions[bot] avatar May 23 '24 03:05 github-actions[bot]