Shopify
[Feature]: Add flag to make `theme push` idempotent
What area(s) will this request affect?
Theme
What type of change do you want to see?
New feature
Overview
Would it be possible to add a flag that makes theme push idempotent?
Given a theme name, it would only create a single theme with that name.
Right now, if the --unpublished flag is passed, it will create multiple themes with the same name. Without --unpublished, it will error if the theme isn't created.
What I'd like is the ability to run theme push --theme jeff/feature-branch multiple times and only have a single theme created.
Motivation
To support PR reopening in a GitHub, we need the ability to push to a theme named after a branch multiple times and have only a single theme created.
In the pre-1.0 release of Shopkeeper I had to add a create command in order to make this possible.
I walk through how someone can use GitHub Actions to write workflows to provide a CI/CD experience for Shopify like you might have with other tools like Heroku or Vercel's branch previews.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Not sure how to keep this open... The problem is a bit of a tricky one in terms of the existing command and flags. @isaacroldan do you have a sense of whether we should pursue a fix for this in the CLI or if I should continue to handle it with my plugin?
I'm happy to contribute a change, but would need guidance to align it with Shopify's vision.
Hi @jeffreyguenther, thanks for the proposal. @karreiro or @mgmanzella would be better to answer you this question :)
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue ist still relevant and always should have been the default behavior.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.
This issue seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action. → If there's no activity within a week, then a bot will automatically close this. Thanks for helping to improve Shopify's dev tooling and experience.
P.S. You can learn more about why we stale issues here.