app_profiler icon indicating copy to clipboard operation
app_profiler copied to clipboard

Centralize Ruby Version to `.ruby-version`

Open jenshenny opened this issue 1 year ago • 2 comments

What are you trying to accomplish?

The .ruby-version file is the ecosystem standard for defining a Ruby version. This PR adds the .ruby-version file, ensures a required_ruby_version is set, and removes all other references to Ruby in this repository, aligning it with the standard.

What should reviewers focus on?

[!IMPORTANT] Please verify the following before merging:

Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:

  • [ ] .ruby-version file is present with the correct Ruby version defined
  • [ ] A required_ruby_version in your gemspec is set
  • [ ] There is no Ruby version present in the dev.yml Ruby task (before: - ruby: x.x.x, after: - ruby)
  • [ ] There is no Ruby version/requirement referenced in the Gemfile (no lines with ruby <some-version>)
  • [ ] A Gemfile.lock is built with the defined Ruby version
  • [ ] The version of Rubocop installed is 1.61.0 or greater
  • [ ] There is no TargetRubyVersion defined in rubocop.yml (reads from required_ruby_version on Rubocop 1.61.0)
  • [ ] There is no Ruby argument present in ruby/setup-ruby Github Actions that do not run on a Ruby matrix (no lines with ruby-version: “x.x”)

To establish consistency, the required_ruby_versionis set to 2.7. If you think that another version is a better fit, please make the applicable changes.

Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.

jenshenny avatar Mar 26 '24 21:03 jenshenny

@dalehamel that makes sense! Here's the PR https://github.com/Shopify/app_profiler/pull/119. Let me know when https://github.com/Shopify/app_profiler/pull/101 merges and I can apply the remaining changes.

jenshenny avatar May 03 '24 14:05 jenshenny

@jenshenny sorry for the conflicts here. I resolved the ones on #119 and added 3.3 to the CI matrix and merged it. Could you please rebase and do another pass? Thanks for waiting to #101 to land.

dalehamel avatar May 03 '24 14:05 dalehamel

@dalehamel rebased! Sorry for the delay, was on vacation for the last little while and wasn't able to get to it until now

jenshenny avatar Jun 18 '24 18:06 jenshenny