webpush-go

webpush-go copied to clipboard

Basically, the same as this [old issue](https://github.com/SherClockHolmes/webpush-go/issues/40). firefox and chrome works fine, but for edge, i get 406 error When I inspect the header for the error response, I see...

eugbyte

Wrong Subscription.Keys.Auth value does not return an error

1

Wrong `Subscription.Keys.Auth` value does not return an error For example, if I were to append a random value to the Auth field as such, ``` sub := &webpush.Subscription{ Endpoint: endpoint,...

eugbyte

This seems like a micro-optimization, but we are running this code in a tight loop and this saves 5 unnecessary allocations.

Richtermeister

We have a use-case to customize the expiration time for the vapid token. This adds this functionality in a backwards compatible fashion.

Richtermeister

At https://github.com/SherClockHolmes/webpush-go/blob/master/webpush.go#L186 the `Content-Length` header is set to `len(ciphertext)`. This is the wrong value but it doesn't matter because somehow the `net/http library` sets the value to the actual length...

dskloet

ECDH output on P-256 curve must be always 32 bytes

1

big.Int Bytes() returns dynamically length byte string, while SEC1 ECDH procedure is defined to output a fixed length byte string (in big-endian). > https://www.secg.org/sec1-v2.pdf > SEC1: 6.1.3. Key Agreement Operation...

sorah

MS Edge rejects push messages

2

When I use the default `Options.TTL` of 0, the Windows Push Notification Service (WNS) rejects the request with status 400 and these headers: ``` X-Wns-Error-Description: Ttl value conflicts with X-WNS-Cache-Policy....

mrwonko

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.9.0 to 0.17.0. Commits 9d2ee97 ssh: implement strict KEX protocol changes 4e5a261 ssh: close net.Conn on all NewServerConn errors 152cdb1 x509roots/fallback: update bundle fdfe1f8 ssh: defer channel...

dependabot[bot]

Allow VAPID sub to be an HTTPS URL

4

The RFC says: > The "sub" claim SHOULD include a contact URI for the application > server as either a "mailto:" (email) [RFC6068] or an "https:" > [RFC2818] URI. However...

emersion

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.9.0 to 0.16.0. Commits 325b735 ssh/test: skip TestSSHCLIAuth on Windows 1eadac5 go.mod: update golang.org/x dependencies b2d7c26 ssh: add (*Client).DialContext method 1c17e20 ssh: fix certificate authentication with OpenSSH...

dependabot[bot]