SyliusFeedPlugin icon indicating copy to clipboard operation
SyliusFeedPlugin copied to clipboard

Do not process already processing feed

Open arjanfrans opened this issue 4 years ago • 2 comments

I am currently having a problem that my monitoring tool is getting a lot of errors; I have a cron job running; that processes the feeds every minute. From what I understand what is happening here; if the feed is already processing, and is then being processed again, then it will throw the The feed is not in a valid state. State is processing exception.

In my opinion this shouldn't really be an exception. Throwing this exception can be avoided by not processing 'already processing' feeds, right?

image

image

arjanfrans avatar Nov 05 '21 09:11 arjanfrans

I believe this can be fixed this way:

  • (at plugin repository) Create findReadyToBeProcessed rather than findEnabled which return enabled records in proper state.
  • (at server side) Run processing not so frequently

igormukhingmailcom avatar Nov 05 '21 11:11 igormukhingmailcom

I am aware that running it so frequently doesn't make sense; but I did that since I was still in a testing phase. Anyway, this should be fixed, since it is an exception that shouldn't really happen.

arjanfrans avatar Nov 05 '21 11:11 arjanfrans