weaver icon indicating copy to clipboard operation
weaver copied to clipboard

Remove CGO dependencies

Open johanbrandhorst opened this issue 2 years ago • 1 comments

https://github.com/ServiceWeaver/weaver/issues/79 reported an issue building on MacOS, which was resolved by explicitly documenting installation instructions. However, during the discussion, the idea of removing the sqlite CGO depencency was raised. I would like to revive this discussion as I believe there are many reasons to remove any CGO dependencies in a Go project including:

  • Trivial cross compilation
  • Higher performance
  • Fewer build dependencies
  • Fewer build headaches for users (I'm here because I had a distinct CGO build error from the one in #79).

Please replace the CGO sqlite driver with the CGO free one from https://pkg.go.dev/modernc.org/sqlite.

johanbrandhorst avatar Mar 04 '23 02:03 johanbrandhorst

@johanbrandhorst thanks for raising this.

After #79 has been closed by updating the documentation, I also returned to this issue for the exact same arguments already mentioned above.

breml avatar Mar 05 '23 10:03 breml

Thanks for reporting, see the attached pull request.

spetrovic77 avatar Mar 05 '23 19:03 spetrovic77