weaver icon indicating copy to clipboard operation
weaver copied to clipboard

remove duplicates of default registry dir implementations

Open shivas opened this issue 2 years ago • 3 comments

extract DefaultRegistryDir into the separate package, so that it could be used /runtime/perfetto btw, there is a possible bug if the storage folder has not cleaned up registry files, then status metrics and dashboard commands will fail to attempt to connect to not accepting port with the error:

Get "http://127.0.0.1:56018/debug/serviceweaver/status": dial tcp 127.0.0.1:56018: connectex: No connection could be made because the target machine actively refused it.

and won't continue to the next service running

P.S. naming is hard, so open to suggestions of package names. Separate package due to import loop.

shivas avatar Mar 02 '23 23:03 shivas

@spetrovic77 changes applied

shivas avatar Mar 08 '23 00:03 shivas

@spetrovic77 any updates on this?

shivas avatar Mar 10 '23 11:03 shivas

GitHub says this branch is out-of-date with the base branch. Mind rebasing on top of main?

mwhittaker avatar Mar 10 '23 17:03 mwhittaker

GitHub says this branch is out-of-date with the base branch. Mind rebasing on top of main?

Op, actually I realize I can do this on your behalf :) I'll merge this PR in just a sec.

mwhittaker avatar Mar 10 '23 18:03 mwhittaker