Fixing escape issues with curl and zsh

Open danielmapar opened this issue 2 years ago • 2 comments

Issue here

Mar 07 '23 00:03 danielmapar

Hi @danielmapar! Thanks for the fix. I'm not super familiar with zsh. Could we escape things using single quotes instead of backslashes like this:

curl 'localhost:12345/hello?name=Weaver'

If that does work, I think it's a bit easier to read?

Mar 07 '23 01:03 mwhittaker

@mwhittaker very good point, and yes " works as well. I updated the PR to use " instead of escaping chars with \.

Mar 07 '23 01:03 danielmapar

I re-based the PR branch @mwhittaker, let me know if I need to do any further steps to get it merged.

Mar 07 '23 19:03 danielmapar

Merged! Thanks so much for your contribution @danielmapar!

Mar 07 '23 19:03 mwhittaker