ServiceNowDevProgram
Cool of reviewers on pull requests
Problem A lot of excited reviewers trying to chip in as much and fast as possible. Resulting in millisecond assignments. Great! But also leaving people to mis the (micro small) assignment window each time.
Proposal Add a GitHub Action that:
- Checks if reviewers have met the Hacktober threshold and a threshold for the day (let's say 2 for each repository).
- Prevent them to assign or be assigned to for the first hour(?) of the PR being open within that repo.
Goal Allow other reviewers to assign and review.
@WillemZeiler Hello! I'd love to contribute and work on this issue for Hacktoberfest.
After reviewing the details, my initial plan is to [Briefly describe your approach, e.g., "create a new GitHub Action workflow file in .github/workflows/ that triggers on pull_request events and uses a script to check the author's recent activity via the GitHub API."]
This approach seems to align with the proposal's goal of creating a fairer review process. Could you please assign this to me?
Hi @Pratham7249 - I appreciate your eagerness. However, we are not yet ready for this issue to be actioned, as further discussion around this feature should be held
- Checks if reviewers have met the Hacktober threshold and a threshold for the day (let's say 2 for each repository).
@WillemZeiler Could you please walk me through what you mean by Hacktober threshold? Maintainer actions aren't really rewarded by DigitalOcean, so I'm trying to get my head around this. I do appreciate your concern though, this is just a part I'm hoping to understand better.
@SapphicFire I am referring to this:
"Ways for sndevs designated approvers to earn points:
Approving and merging a pull request = 1 point Closing an issue = 1 point Closing a pull request without merging = 1 point"
https://github.com/ServiceNowDevProgram/Hacktoberfest
Allowing people to get to that point and then prevent them from assigning multiple to themselves at once will give others a better opportunity to also join in. I would prefer even blocking people to assign multiple to themselves in a short period while their other PR's are still open, but that is a bit more strickt.