BUG: 404 route not working on root route '/'

[saivishwak]

Resolve #257

Description:

Redirect to page not found not working on root route

Usually everyone tends to type something on the root route ("/") to navigate to the next page. With the existing approach this feels a like a bad ux experience. And also later when the app needs to have different routes which are not related to data, they can go to their route like /settings/my_profile , /users/:userID. This will be useful when the app grows.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

• [x] ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
• [x] PRE-COMMIT. You ran pre-commit on all commits, or else, you ran pre-commit run --all-files at the end.
• [ ] USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact our users.
• [ ] DEV CHANGES.
  • Update the documentation if this PR changes how to develop/launch on the app.
  • Update the README files and our wiki for any big design decisions, if relevant.
  • Add unit tests, docstrings, typing and comments for complex sections.

[gabegma]

Thank you @saivishwak for adding issues to our repo and creating your first PR! This is really appreciated. @christyler3030, could you take a look?

[christyler3030]

Hi @saivishwak thanks for raising this issue. We definitely need to handle these urls better but I think the fix will need to be deeper than this fix. For example, with this fix we still have the same undesired behaviour at the url: http://localhost:3005/app/asdfasdfasdfadf instead of http://localhost:3005/asdfasdfasdfadf

We will discuss some of the architectural concerns and will keep you informed. Thanks for the contribution!

[saivishwak]

Hi @christyler3030 ,

Sure thanks a lot for your reply. Yes it does have same behavior at app/asdasfdasdf. My thought process was, its easier to get messy from home root ("/") so added another additional route.

[gabegma]

I will close this PR, given the discussion. However, it would be great to find a lasting solution to this problem @christyler3030 @JosephMarinier. Thanks again @saivishwak for taking a stab at it!