ErrorProne.NET

ErrorProne.NET copied to clipboard

Wrong "in" Keyword suggestion when struct is stored in a collection of tuples

1

List myStructTupleList = new (); MyMethod(in myStruct)//example method MyMethod(in myStructTupleList[0].ms) //does not compile with the "in" keyword

Aniobodo

False warnings for ArraySegment<T>

1

`ArraySegment` is a readonly struct, but analyzer thinks it is not and always gives ESP06 warning.

helviett

In the README file there is a link to a Visual Studio pipeline but it appears to be broken now: https://github.com/SergeyTeplyakov/ErrorProne.NET/blob/master/ReadMe.md The image isn't loading and when clicked, leads to...

richardsondev

Xyncgas

Violations show up on generated code

2

We've started to use the [generated HTTP clients](https://devblogs.microsoft.com/dotnet/generating-http-api-clients-using-visual-studio-connected-services/) that uses [NSwag](https://github.com/RicoSuter/NSwag) to generate a typed client, and EPS01 "Struct 'ObjectResponseResult' can be made readonly" is showing up on the generated...

tiesmaster

Several CodeFixProviders throw MissingMethodException

1

This is with current head of master f6787c08d76ca761eee3d103f43c4289bbb4d3cb, running in VS 16.11.7. Packaging issue suspected, I'm investigating.  ``` System.MissingMethodException : Method not found: 'System.String ErrorProne.NET.StructAnalyzers.ExplicitInParameterAnalyzer.get_DiagnosticId()'. at ErrorProne.NET.StructAnalyzers.ExplicitInParameterCodeFixProvider.get_FixableDiagnosticIds() at Microsoft.CodeAnalysis.CodeFixes.CodeFixService.GetAndTestFixableDiagnosticIds(CodeFixProvider...

tg73

At current HEAD of master, it's this (literally): ``` { "sdk": { > Stashed changes } } ``` Which version should it be?

tg73

This should be flagged as suspicious code: ```csharp public struct MyDisposable : IDisposable { public void Dispose() { } } internal class Program { static Task FooBar() { return Task.FromResult(0);...

SergeyTeplyakov

EPS12 produces false positive on methods of non-readonly structs

5

EPS12 falsely reports that a method can be readonly on a non-readonly struct. This is nonsense, since there is no such thing (yet) as a readonly method. A picture says...

shuebner

For instance, if the application uses C# 7.2, do not emit a warning that a method can be made readonly, because the fix will produce a non-compilable code. Consider emitting...

SergeyTeplyakov