piece of thought: redundant code cause LAN mode failing

Open fakeboboliu opened this issue 1 year ago • 0 comments

Many modpacks using this mod, and it causes LAN servers failed to be connected.

Looks like caused by following codes:

https://github.com/SeraphJACK/SimpleLogin/blob/afdda60e78af23889e0ed067fb84547a62cf4c41/src/main/java/top/seraphjack/simplelogin/client/ClientLoader.java#L17-L21

It might be unnecessary for client sending password at the very beginning, since server sends a request login message while logging in:

https://github.com/SeraphJACK/SimpleLogin/blob/afdda60e78af23889e0ed067fb84547a62cf4c41/src/main/java/top/seraphjack/simplelogin/server/ServerSideEventHandler.java#L30

And the client seems handles it correctly:

https://github.com/SeraphJACK/SimpleLogin/blob/afdda60e78af23889e0ed067fb84547a62cf4c41/src/main/java/top/seraphjack/simplelogin/network/MessageRequestLogin.java#L23-L28

It should be safe to remove those redundant codes in ClientLoader.

Oct 10 '24 14:10 fakeboboliu