minecraft-mod-manager icon indicating copy to clipboard operation
minecraft-mod-manager copied to clipboard
verified publisher icon Senth

Sourcery Refactor (Includes #197)

Open Bluscream opened this issue 3 years ago • 2 comments

What changed?

Testing

  • [ ] Added unit tests
  • [ ] Added integration tests
  • [ ] ...Your own tests...

Checklist

  • [x] I have reviewed my own code

Related Issues

Fixes

Bluscream avatar Jul 31 '22 18:07 Bluscream

Hmm, some of these were quite nice cleanups, but some I'm a bit unsure of. I usually want to keep the if-statements short, and rather have short lines than long lines.

I might go through these and remove and change the refactoring which isn't used.

Senth avatar Aug 02 '22 20:08 Senth

There's absolutely no obligation to use any of this, the code is fine as is. I just like being reminded of where code i use can be improved/rethought ^^

Bluscream avatar Aug 03 '22 02:08 Bluscream