Linting / Precommit Hooks

Open joshua-dean opened this issue 2 years ago • 3 comments

Could use some standardization and some dev environment hook setups to keep the code structure clean

Feb 15 '23 17:02 joshua-dean

@TrevorBurgoyne @csolbs24 I'm thinking we go with ESLint and prettier, with both being ran as pre-commit hooks. Any qualms with these? If there's something we'd rather use, I'm open to it. I'll have a PR with the formatting changes so that we can split hairs over linting/formatting rules before anything is official.

Sep 27 '24 17:09 joshua-dean

I opened #175 as a draft. It uses husky as I liked it's terminal outputs better than the pre-commit on npm (which is apparently different from the python one).

ESLint finds 232 errors so it might be wise to merge it and fix files as they're edited. Thoughts?

Sep 27 '24 18:09 joshua-dean

#175 solves some initial linting/formatting concerns.

Three things we haven't addressed:

[ ] JSDoc / TSDoc enforcement
[ ] Line length
[ ] Importing sorting / automatic removal of unused imports

Oct 03 '24 16:10 joshua-dean