NNfSiX icon indicating copy to clipboard operation
NNfSiX copied to clipboard

First three lessons in Idris

Open witt3rd opened this issue 5 years ago • 4 comments

Following the Python style (i.e., non-idiomatic Idris)

witt3rd avatar Aug 20 '20 08:08 witt3rd

Hi, Thank you for this submission. For various reasons we need to keep a full and complete lesson code in a single file, could you please update your implementation according to this?

daniel-kukiela avatar Dec 24 '20 02:12 daniel-kukiela

Lesson 4 in Python includes: import numpy as np import nnfs from nnfs.datasets import spiral_data # See for code: https://gist.github.com/Sentdex/454cb20ec5acf0e76ee8ab8448e6266c

Idris has no "numpy" equivalent, which is why I created a util module. You are asking me to essentially inline what the Python version imports?

witt3rd avatar Dec 24 '20 13:12 witt3rd

If there is some external package that you can simply install (like pip install numpy for example in Python), then you are free to use it of course. If you need to create some code by hand - yes, please contain it within this file. I understand that this code is going to be repeated in the next parts, but that's desired, and also solves multiple possible issues in the future (someone else taking over is original maintainer stop committing solutions, backward compatibility issues, maintain issues, etc). I hope that this makes sense for you :)

daniel-kukiela avatar Dec 28 '20 19:12 daniel-kukiela

Hey, Will you update your code to follow the guidelines? I'd like to merge this into the repository, but I don't feel like pushing updates by myself for this language :)

daniel-kukiela avatar Jan 16 '21 16:01 daniel-kukiela