seleniumhq.github.io icon indicating copy to clipboard operation
seleniumhq.github.io copied to clipboard

translate Grid documents into Japanese

Open rerorero opened this issue 3 years ago • 5 comments

Thanks for contributing to the Selenium site and documentation! A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines. Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR translates Grid documents into Japanese.

Motivation and Context

Types of changes

  • [ ] Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • [ ] Code example added (and I also added the example to all translated languages)
  • [ ] Improved translation
  • [x] Added new translation (and I also added a notice to each document missing translation)

Checklist

  • [x] I have read the contributing document.
  • [x] I have used hugo to render the site/docs locally and I am sure it works.

rerorero avatar Aug 09 '22 16:08 rerorero

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 09 '22 16:08 CLAassistant

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
Latest commit a0f8aca672792d1f964af7c18a0ee6fa6e9b3c80
Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/62f290c483e16e0009b66f7d
Deploy Preview https://deploy-preview-1112--jovial-austin-42fe02.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 09 '22 17:08 netlify[bot]

Deploy Preview for jovial-austin-42fe02 ready!

Name Link
Latest commit 9d3291ee877bf2914eb72f0da095095c96bb5d19
Latest deploy log https://app.netlify.com/sites/jovial-austin-42fe02/deploys/6387ee792552f1000822cb6d
Deploy Preview https://deploy-preview-1112--jovial-austin-42fe02.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 09 '22 17:08 netlify[bot]

What's wrong? 🤔

rerorero avatar Aug 10 '22 04:08 rerorero

Okay, I will revisit it once you update the documents.

rerorero avatar Aug 22 '22 11:08 rerorero

@rerorero Sorry, I forgot to reply. The docs have been updated already a while ago. Would you like to have a look again?

diemol avatar Nov 01 '22 13:11 diemol

Thank you for letting me know, let me take a look again.

rerorero avatar Nov 07 '22 07:11 rerorero

@diemol I updated this branch based on the latest trunk. PTAL.

rerorero avatar Nov 09 '22 09:11 rerorero

@rerorero Thank you for translating the Grid chapter. I'm still reviewing, and it takes a lot of time. Most of my comments are to make the words bold. Sorry to trouble you, but could you please check my comment?

kzhirata avatar Nov 09 '22 12:11 kzhirata

@kzhirata Thank you for taking a look, I updated according to your comments.

rerorero avatar Nov 11 '22 00:11 rerorero

@rerorero I've reviewed "website_and_docs/content/documentation/grid/getting_started.ja.md" and add some comments.

The rest of my review is below.

  • website_and_docs/content/documentation/grid/configuration/_index.ja.md
  • website_and_docs/content/documentation/grid/configuration/cli_options.ja.md
  • website_and_docs/content/documentation/grid/configuration/help.ja.md
  • website_and_docs/content/documentation/grid/configuration/toml_options.ja.md

kzhirata avatar Nov 11 '22 13:11 kzhirata

Thanks, updated again.

rerorero avatar Nov 15 '22 11:11 rerorero

oops, sorry for this bold nightmare... updated again.

rerorero avatar Nov 21 '22 11:11 rerorero

Sorry for late, updated again.

rerorero avatar Nov 30 '22 11:11 rerorero

Fixed again.

rerorero avatar Dec 01 '22 00:12 rerorero

Thank you @rerorero !

kzhirata avatar Dec 01 '22 12:12 kzhirata