selenium icon indicating copy to clipboard operation
selenium copied to clipboard

[rb] Add all the RBS files to add full rbs support to all selenium rb classes and modules

Open aguspe opened this issue 2 years ago • 0 comments

Description

This PR adds more than 120 RBS files and updates the steep file to reduce all the current steep errors. The goal with this PR is that afterward it would be possible to add a steep check on the bazel pipeline.

Motivation and Context

Based on #10943 I created the following PRs to add RBS type support to the ruby selenium library:

On #12844 I started adding support for RBS and I added the steep file configuration On #13192 I extended the classes supported on RBS and updated the logger file

I stated on #13192 that I wanted to make smaller PRs to expand support and make it easier to review, but since there was a lot of work to be done to cover all the classes and modules in the library I decided to expand this PR to add all the missing coverage and fix all the steep issues

Right now if a steep check is run after the two previously mentioned PRs this is the result:

Screenshot 2023-12-02 at 20 31 30

Already with the files added and the extension of libraries on the steep config file the amount of errors drops to:

Screenshot 2023-12-02 at 19 57 48

This is currently a work in progress and I will submit this PR after all the type errors are reduced to 0 and all the files are properly updated to reflect the right types used in classes and not just undefined

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x] I have read the contributing document.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

aguspe avatar Dec 02 '23 19:12 aguspe