MLServer icon indicating copy to clipboard operation
MLServer copied to clipboard

Enable control of logging to be more granual

Open dtpryce opened this issue 3 years ago • 2 comments

Currently setting debug=true stops ALL logging which is fine for some use cases but others may want to still see some logging (ours). The behaviour we would love to see is that we can set per endpoint or group of endpoints a log level or verbosity. e.g. inference_logging = INFO | DEBUG | WARN | CRITICAL | OFF, metric_logging = same, probe_logging = same. And that this is then reflected up into Seldon Core.

dtpryce avatar Jan 23 '23 10:01 dtpryce

Hey @dtpryce ,

Thanks for opening this one!

That's an interesting suggestion. Initially, I was just thinking of keeping the probes logs separate, but I agree that a second flag for metrics could also make sense.

adriangonz avatar Jan 25 '23 10:01 adriangonz

Hey @adriangonz yeah was making sure to be thorough I guess and can definitely see some use case in being able to turn on different endpoint logging selectively. For us it would be probe = OFF, metric = INFO, inference = INFO I think and ensuring this goes up to Seldon so that we have the right logging format at that level has become important too!

I will follow along, sadly not sure I can contribute too much on this one.

dtpryce avatar Jan 25 '23 10:01 dtpryce