MLServer icon indicating copy to clipboard operation
MLServer copied to clipboard

Python 3.12 support

Open SergeyShk opened this issue 1 year ago • 2 comments

Is there any plan to add support for Python 3.12? It was released over a year ago and many projects are already making use of it

SergeyShk avatar Oct 14 '24 14:10 SergeyShk

Kind of reminder

SergeyShk avatar Oct 18 '24 10:10 SergeyShk

@SergeyShk there are no immediate plans however we encourage contributions from the community and could provide pointers to progress it towards this direction.

sakoush avatar Oct 18 '24 14:10 sakoush

@sakoush Alright, could you share the information on what needs to be done to update the supported version of Python?

SergeyShk avatar Oct 28 '24 11:10 SergeyShk

@sakoush I would like to work on this issue.

shivakrishnaah avatar Nov 09 '24 04:11 shivakrishnaah

shivakrishnaah It would be quite a hassle to go directly to the support up to version 3.13.

sergioave avatar Nov 11 '24 12:11 sergioave

Hi team, any update on this? We are working on a high priority project and are using mlserver for its asynchronous serving capabilities. We have to migrate to python 3.12 because of company policies and hence would love if this library supports 3.12.

Singhal-harsh avatar Nov 27 '24 12:11 Singhal-harsh

@Singhal-harsh, @shivakrishnaah has a draft PR: https://github.com/SeldonIO/MLServer/pull/1951 to add support for python 3.12.

However we realised that we need to upgrade some of the internal libraries that mlserver is using (alibi and alibi-detect), which should be done before accepting #1951

We are actively working to upgrade these deps to support python 3.12; as we have also other priorities I cant give an estimate at the moment when they are likely to be done though.

sakoush avatar Nov 28 '24 12:11 sakoush

It looks like alibi and alibi-detect have been successfully upgraded to support Python 3.12.

does that give MLServer the all clear to pull in 3.12 support?

BJohnBraddock avatar Dec 12 '24 19:12 BJohnBraddock

yes, ongoing work can be tracked in https://github.com/SeldonIO/MLServer/pull/1951

sakoush avatar Dec 13 '24 17:12 sakoush

https://github.com/SeldonIO/MLServer/pull/1951 is now merged. mlserver supports py3.9-py3.12. thanks @shivakrishnaah for providing help on this work. @RobertSamoilescu did alibi libraries upgrades that unblocked this change.

sakoush avatar Dec 17 '24 17:12 sakoush