sourcespec icon indicating copy to clipboard operation
sourcespec copied to clipboard

V2 fix no response

Open krisvanneste opened this issue 3 months ago • 3 comments

This PR fixes a problem that occurs when traces are passed to sourcespec where instrument response is already removed and the station inventories do not contain response information (which should not be needed in this case).

Note that this branch is based on v2_interactive_plotting (PR https://github.com/SeismicSource/sourcespec/pull/75). Only the last commit (f4cc84d0db59a31a89f82ae3534319da226b0ad1) is relevant. I hope that's OK.

krisvanneste avatar Oct 28 '25 15:10 krisvanneste

Hi Kris, I rebased this PR on current v2, force-pushed and rephrased the commit message.

Still need to test it, though...

claudiodsf avatar Dec 19 '25 18:12 claudiodsf

I also split into two helper functions to have a clearer diff of what you changed (and a more readable code😉)

claudiodsf avatar Dec 19 '25 18:12 claudiodsf

Still need to test it, though...

I ran a test and it works!

krisvanneste avatar Dec 22 '25 09:12 krisvanneste