scuffle icon indicating copy to clipboard operation
scuffle copied to clipboard

feat: foundations

Open TroyKomodo opened this issue 1 year ago • 1 comments

Proposed changes

Describe the big picture of what you want to change here, to help the maintainers understand why we should accept this pull request. Be sure to link to the issue if it fixes a bug or resolves a feature request.

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • [ ] I have read the CONTRIBUTING doc
  • [ ] Lint and unit tests pass locally with my changes
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added necessary documentation (if appropriate)
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

TroyKomodo avatar Apr 29 '24 18:04 TroyKomodo

Codecov Report

Attention: Patch coverage is 28.38312% with 5922 lines in your changes missing coverage. Please review.

Project coverage is 21.87%. Comparing base (52ac456) to head (5f095a4). Report is 27 commits behind head on feature/website.

:exclamation: Current head 5f095a4 differs from pull request most recent head 556db56

Please upload reports for the commit 556db56 to get more accurate results.

Files with missing lines Patch % Lines
image-processor/src/management/validation.rs 0.00% 557 Missing :warning:
foundations/src/http/server/stream/quic.rs 0.00% 290 Missing :warning:
image-processor/src/worker/process/resize.rs 0.00% 288 Missing :warning:
foundations/src/telemetry/opentelemetry/layer.rs 0.00% 276 Missing :warning:
image-processor/src/worker/process/blocking.rs 0.00% 274 Missing :warning:
foundations/src/telemetry/opentelemetry/node.rs 0.00% 237 Missing :warning:
image-processor/src/worker/process/mod.rs 0.00% 195 Missing :warning:
foundations/src/telemetry/env_filter/env/field.rs 39.62% 192 Missing :warning:
foundations/src/telemetry/env_filter/env/mod.rs 46.94% 191 Missing :warning:
foundations/src/telemetry/settings.rs 0.00% 183 Missing :warning:
... and 73 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##           feature/website     #209       +/-   ##
====================================================
- Coverage            46.72%   21.87%   -24.86%     
====================================================
  Files                  486      102      -384     
  Lines                30818    10731    -20087     
====================================================
- Hits                 14399     2347    -12052     
+ Misses               16419     8384     -8035     
Files with missing lines Coverage Δ
ffmpeg/src/decoder.rs 0.00% <ø> (-60.98%) :arrow_down:
ffmpeg/src/encoder.rs 0.00% <ø> (ø)
ffmpeg/src/filter_graph.rs 0.00% <ø> (ø)
ffmpeg/src/io/internal.rs 0.00% <ø> (-64.59%) :arrow_down:
ffmpeg/src/io/output.rs 0.00% <ø> (-47.42%) :arrow_down:
ffmpeg/src/packet.rs 0.00% <ø> (-37.94%) :arrow_down:
ffmpeg/src/scalar.rs 0.00% <ø> (-89.37%) :arrow_down:
image-processor/src/worker/process/libwebp.rs 0.00% <ø> (ø)
foundations/macros/src/lib.rs 95.00% <95.00%> (ø)
foundations/macros/src/settings/types/field_ty.rs 97.61% <97.61%> (ø)
... and 81 more

... and 444 files with indirect coverage changes

codecov[bot] avatar Jun 23 '24 15:06 codecov[bot]