ScotterC
Unused code / opportunity for Filter Contract
Currently we have some very nice unused code, Filter which would do a good job of validating filter params. It's not currently in use right now but would be with a small change here
The reason is that the Filter class doesn't pass it's filter attributes into the Query class and therefore the values get lost silently. This test can be easily modified to see what's happening. Modifying the filter class, probably with an attribute could resolve the issue.
I could help with this @ScotterC . Do you have any additional comments since the creation of this issue?
@pyrabbit that'd be great! Since this was introduced, I feel a bit mixed on having the dependency on dry-struct/dry-validation. They're nice to have to ensure a valid Filter object but if you find that they're not doing any real heavy lifting then I'd be up for scrapping it.
@ScotterC Thanks for the feedback.. This evening I'll work on trying to put something together for this change.