Display most recent Umbra announcement time/block on receive page
Resolves #632
Deploy Preview for jolly-shaw-20fe62 ready!
| Name | Link |
|---|---|
| Latest commit | 1651980483c6da4b9250655c8180464d8e60a513 |
| Latest deploy log | https://app.netlify.com/sites/jolly-shaw-20fe62/deploys/662ab4eeaae7b000098d2708 |
| Deploy Preview | https://deploy-preview-657--jolly-shaw-20fe62.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@jferas I feel like
-
I liked the message being on top of the receive table, so it's easier to see if you have many transactions.
-
Date/block number and the rest of the message seem to be out of order.
-
I think we can skip showing the
Most recent mined block and timestamp, as it should be easy enough to lookup. Or only show it in advanced mode to make sure user rpc is working properly.
Fixed latest: 9114d1817cfc9403f3ea0be04bdf3ba88c633315
Coverage after merging show-most-recent-announcement into master will be
| 81.12% |
|---|
Coverage Report
| File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
|---|---|---|---|---|---|
| contracts-periphery/src | |||||
| UmbraBatchSend.sol | 100% | 100% | 100% | 100% | |
| UniswapWithdrawHook.sol | 81.82% | 100% | 66.67% | 83.33% | 14 |
| umbra-js/src | |||||
| ethers.ts | 76.27% | 100% | 61.11% | 100% | |
| types.ts | 50% | 100% | 0% | 100% | |
| umbra-js/src/classes | |||||
| KeyPair.ts | 98.65% | 96.49% | 100% | 100% | 31–32 |
| RandomNumber.ts | 100% | 100% | 100% | 100% | |
| StealthKeyRegistry.ts | 100% | 100% | 100% | 100% | |
| TxHistoryProvider.ts | 77.55% | 76.47% | 66.67% | 79.31% | 11, 11, 19–20, 31, 38, 44, 53, 57, 8 |
| Umbra.ts | 75.41% | 63.69% | 82.93% | 82.09% | 105, 135–136, 157, 229–231, 315–318, 380, 394, 401–403, 405–406, 409–410, 428, 430, 432, 432, 432, 432–433, 433, 433–435, 450, 450, 450–451, 455, 458, 478, 496–498, 585, 602, 615–616, 626–627, 640, 643–644, 674–675, 751, 755, 755, 755–758, 758, 758, 758, 758, 758, 758–759, 759, 759, 759, 759, 759, 759, 759, 759, 759, 759, 761, 761, 761–762, 765, 765, 765, 765, 765–766, 769, 778, 778, 787, 790, 790, 790–792, 805, 809, 812–813, 819–821, 828, 828, 828–831, 862, 867–868, 868–869 |
| umbra-js/src/typechain | |||||
| index.ts | 70.59% | 100% | 37.50% | 100% | |
| umbra-js/src/typechain/factories | |||||
| index.ts | 100% | 100% | 100% | 100% | |
| umbra-js/src/typechain/factories/@openzeppelin | |||||
| index.ts | 100% | 100% | 100% | 100% | |
| umbra-js/src/typechain/factories/@openzeppelin/contracts | |||||
| index.ts | 100% | 100% | 100% | 100% | |
| umbra-js/src/typechain/factories/@openzeppelin/contracts/access | |||||
| Ownable__factory.ts | 50% | 100% | 0% | 66.67% | 70, 76 |
| index.ts | 50% | 100% | 0% | 100% | |
| umbra-js/src/typechain/factories/@openzeppelin/contracts/token | |||||
| index.ts | 100% | 100% | 100% | 100% | |
| umbra-js/src/typechain/factories/@openzeppelin/contracts/token/ERC20 | |||||
| ERC20__factory.ts | 29.03% | 0% | 12.50% | 47.06% | 310, 314, 314, 314–315, 317, 326, 326, 326, 333, 333, 333, 336, 339, 345 |
| IERC20__factory.ts | 50% | 100% | 0% | 66.67% | 201, 204 |
| index.ts | 50% | 100% | 0% | 100% | |
| umbra-js/src/typechain/factories/contracts | |||||
| IUmbraHookReceiver__factory.ts | 50% | 100% | 0% | 66.67% | 61, 67 |
| MockHook__factory.ts | 22.58% | 0% | 0% | 41.18% | 107, 111, 111, 111–112, 114, 121, 121, 121, 126, 126, 126, 129, 132, 138, 144 |
| StealthKeyRegistry__factory.ts | 22.58% | 0% | 0% | 41.18% | 202, 206, 206, 206–207, 209, 216, 216, 216, 221, 221, 221, 224, 227, 233, 239 |
| TestToken__factory.ts | 64.52% | 66.67% | 50% | 70.59% | 329–330, 348, 351, 354, 360, 366 |
| Umbra__factory.ts | 70.97% | 66.67% | 62.50% | 76.47% | 495–496, 525, 529, 532, 538 |
| index.ts | 50% | 100% | 0% | 100% | |
| umbra-js/src/utils | |||||
| cns.ts | 50% | 33.33% | 50% | 55% | 33–36, 40, 40, 40, 40, 40–41, 44–46 |
| constants.ts | 100% | 100% | 100% | 100% | |
| ens.ts | 36.11% | 25% | 33.33% | 40% | 25–27, 35, 56–57, 57, 57–58, 63–64, 66, 70, 70, 70, 70, 70–71, 75–77 |
| utils.ts | 76.67% | 68.66% | 76.92% | 82% | 109–111, 113–115, 121, 139–140, 169, 190, 246, 253–260, 260, 260, 260, 260, 260, 260–261, 263, 294, 296–297, 306, 306, 306–307, 309, 312, 321–322, 363, 380, 380, 380, 400, 429, 431, 436, 448, 448–449, 454, 456–457, 468–472, 478, 480, 522–523, 523, 523–525, 525, 525, 536, 59–60, 779–780, 792–793, 85, 93, 93 |
| umbra-js/test | |||||
| testPrivateKeys.ts | 100% | 100% | 100% | 100% | |
| utils.ts | 100% | 100% | 100% | 100% | |