umbra-protocol icon indicating copy to clipboard operation
umbra-protocol copied to clipboard

Add modals for advanced mode

Open alexkeating opened this issue 3 years ago • 3 comments

Closes #362

Description:

I added two modals one for when "send using recipient's public key is selected" and another on when the send is clicked. I based the copy on the issue and open to improving it.

Screencast from 10-11-2022 07:59:35 PM.webm

alexkeating avatar Oct 12 '22 00:10 alexkeating

Deploy request for jolly-shaw-20fe62 pending review.

Visit the deploys page to approve it

Name Link
Latest commit a5898683d11b4b0d985266e3ab3bba2021755bb6

netlify[bot] avatar Oct 12 '22 00:10 netlify[bot]

Looks and works well @alexkeating, but let's adjust the copy a bit. I'd also like to expand the functionality a bit (sorry for the requirements-on-the-fly here).

* Message title: Remove the exclamation point after "Warning"

* Message Copy: "The receiver will have to enter their account's private key into this app to withdrawal the funds. **Don't use this feature unless you know what you're doing**. [Learn more](http://localhost:8080/faq#how-do-i-send-funds-to-a-user-by-their-address-or-public-key)"

* Functionality: In addition to the warning, add a check box to the second modal displayed after the user clicks "Send" that reads "☐ I acknowledge the risks". The final "Send" button on the modal should be inactive until the user checks the box.

I updated to reflect these requests

alexkeating avatar Oct 13 '22 20:10 alexkeating

Having these weird Bad response and sometimes invalid address errors in the address bar only when Send using recipient's standard public key is selected and an amount that exceeds wallet balance or letters are entered. image

garyghayrat avatar Oct 20 '22 01:10 garyghayrat

Having these weird Bad response and sometimes invalid address errors in the address bar only when Send using recipient's standard public key is selected and an amount that exceeds wallet balance or letters are entered. image

Hmmm, I am not seeing these locally. Is there anything I am doing wrong to reproduce?

Screencast from 10-20-2022 04:54:49 PM.webm

alexkeating avatar Oct 20 '22 20:10 alexkeating