ScootKit
Updated the economy-system
Thanks so much for your contribution - to make review easier, could you provide us with a list of (User facing) changes? Doesn't need to be detailed, but should include the most important changes.
Changes:
- Added ids for items
- Added a select menu for the shop
- Added a shop-message (overview over the shop; gets send in a channel and works like the leaderboard)
Do you have any updates on this?
Unfortunately I hadn‘t any time to finish the fixes. I‘ll try to resolve the problems asap
Also, when /economy crime fails, the money you loose is calculated and taken from your deposited money, instead of your bank money. A possible solution to this would be to take it from where the most money is (take money from bank if there is more, else take it from deposited money).
(Sadly the screenshot is only available in German)
Translation: "You tried to steal a wallet but got caught. You lose 0 🪙."
It really needs help...
Translation:
Balance of elbe#0
Wallet: null 🪙
Bank: null 🪙
All: NaN 🪙
@jateute I have converted this PR to a draft to make it more clear that it isn't ready to be used and work in progress. You can convert it back once it's ready to use.
@jateute I have converted this PR to a draft to make it more clear that it isn't ready to be used and work in progress. You can convert it back once it's ready to use.
Thx, I didn't thought of it :hAA:
Also, when
/economy crimefails, the money you loose is calculated and taken from your deposited money, instead of your bank money. A possible solution to this would be to take it from where the most money is (take money from bank if there is more, else take it from deposited money).(Sadly the screenshot is only available in German)
Translation: "You tried to steal a wallet but got caught. You lose 0 🪙."
It could also work by giving you debt, so you don't lose anything and don't have 0 coins, but rather -X coins.
It really needs help...
Translation:
Balance of elbe#0
Wallet: null 🪙
Bank: null 🪙
All: NaN 🪙
How did you do that? I wasn't able to reproduce that bug. For me the user either doesn't exist or I get normal numerical values
It really needs help...
Translation:
Balance of elbe#0
Wallet: null 🪙
Bank: null 🪙
All: NaN 🪙
How did you do that? I wasn't able to reproduce that bug. For me the user either doesn't exist or I get normal numerical values
I somehow was able to get negative money I think. Sadly the server this screenshot was taken on is deleted now, so I can't check exactly what I did.
It really needs help...
Translation:
Balance of elbe#0
Wallet: null 🪙 Bank: null 🪙 All: NaN 🪙
How did you do that? I wasn't able to reproduce that bug. For me the user either doesn't exist or I get normal numerical values
I somehow was able to get negative money I think. Sadly the server this screenshot was taken on is deleted now, so I can't check exactly what I did.
For me it also works with negative numbers :) Maybe I somehow fixed it
Hi, I'm just checking in, it seems like some conversations were resolved without any comment / change, could you please check again for me (I assumed that you were going to commit more, but it seems like you requested a review and only fixed certain typos)? Thanks (:
~~It seems like I forgot to push the changes. I‘ll check on it later, when I‘m back at the PC ^^~~
Edit: I did :hAA: Now the changes are actually pushed